Skip to content

Conversation

@djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26731

📔 Objective

Add feature flag for chromium importer with ABE

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team as a code owner October 17, 2025 20:20
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Logo
Checkmarx One – Scan Summary & Details1ac85390-ec73-4d37-bcf9-f7436e167108

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.20%. Comparing base (9c0aaf3) to head (bed6f33).
⚠️ Report is 19 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...er/src/services/default-import-metadata.service.ts 84.21% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16926   +/-   ##
=======================================
  Coverage   39.20%   39.20%           
=======================================
  Files        3463     3463           
  Lines       98115    98132   +17     
  Branches    14733    14736    +3     
=======================================
+ Hits        38466    38473    +7     
- Misses      57985    57994    +9     
- Partials     1664     1665    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@harr1424 harr1424 added the needs-qa Marks a PR as requiring QA approval label Oct 17, 2025
@djsmith85 djsmith85 removed the needs-qa Marks a PR as requiring QA approval label Oct 21, 2025
@djsmith85 djsmith85 merged commit bbfdb60 into main Oct 21, 2025
119 of 120 checks passed
@djsmith85 djsmith85 deleted the tools/pm-26731/add-feature-flag-for-chromium-importer-with-abe branch October 21, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants